Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

INIT_CONTAINER_IMAGE default value should include valid tag #9

Closed
donovanmuller opened this issue Jun 4, 2021 · 3 comments · Fixed by #5 or #11
Closed

INIT_CONTAINER_IMAGE default value should include valid tag #9

donovanmuller opened this issue Jun 4, 2021 · 3 comments · Fixed by #5 or #11
Milestone
0.1.1

Comments

@donovanmuller
Copy link
Contributor

The deploy/service.yaml manifest contains a default value for the INIT_CONTAINER_IMAGE of keptnsandbox/job-executor-service-initcontainer.

However, there is not currently an image pushed with a latest tag, so running the Job fails.

The INIT_CONTAINER_IMAGE value should probably include the same tag as the job-executor-service service.
@botchk
Copy link
Collaborator

botchk commented Jun 4, 2021 •
edited
Loading

This should already be fixed with #5, currently in master for the next release.

@botchk botchk linked a pull request Jun 4, 2021 that will close this issue
Set image tags correctly for 0.1.0 release and update readme #5
Merged
@botchk botchk closed this as completed Jun 4, 2021
@botchk botchk added this to the 0.1.1 milestone Jun 4, 2021
@donovanmuller
Copy link
Contributor Author

donovanmuller commented Jun 4, 2021 •
edited
Loading

@yeahservice the PR only changed the value in the Helm ConfigMap (helm/templates/configmap.yaml) though, not the deploy/service.yaml manifest?

@botchk
Copy link
Collaborator

botchk commented Jun 4, 2021

Ah, my bad, I overlooked that one.

@botchk botchk reopened this Jun 4, 2021
@botchk botchk linked a pull request Jun 7, 2021 that will close this issue
Fix tag for initcontainer in deploy/service.yaml #11
Merged
@botchk botchk closed this as completed in #11 Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
2 participants
@donovanmuller @botchk