Skip to content
This repository was archived by the owner on May 3, 2019. It is now read-only.

Create a better graph #18

Closed
kentcdodds opened this issue Mar 6, 2015 · 7 comments
Closed

Create a better graph #18

kentcdodds opened this issue Mar 6, 2015 · 7 comments

Comments

@kentcdodds
Copy link
Owner

Now that you can add your own listener for the digest cycle and watch count, it would be cool to use ChartJS or D3 to create a better graph to display the data.

@rev087
Copy link

rev087 commented Mar 26, 2015

Wouldn't depending on a third party library introduce a potential conflict if the application you're showing stats for uses a different version of that same library?

@kentcdodds
Copy link
Owner Author

Hadn't thought of that. Good point. Since I'm planning on merging this into batarang, I think we may go a different direction anyway. Perhaps we'd show the graph in the developer tools...

@rev087
Copy link

rev087 commented Mar 26, 2015

Do you plan on maintaining a functional standalone version for ng-stats? I'd like to implement it in ng-inspector with your permission.

We haven't decided yet what to do eventually with batarang/ng-inspector (the goal is to eventually merge them) but moving towards a common base is a good first step.

edit: (sorry for deleting/reposting, hit submit by accident before I was done writing)

@kentcdodds
Copy link
Owner Author

I do plan on retiring deprecating ng-stats when it's implemented in batarang. You're more than welcome to implement it in ng-inspector :D

@SomeKittens
Copy link
Contributor

This is twice as tricky as it's being implemented into ng-hint which is to be used in CI, etc. The smartest move may be to put the core ng-stats functionality into an ng-hint module and have a separate module for consuming the data produced by ng-stats-core and displaying a graph.

This way, Batarang could display a graph in DevTools, inspect could place it on the page - everyone gets flexibility.

@kentcdodds
Copy link
Owner Author

👍 I like that approach.

@rev087
Copy link

rev087 commented Mar 27, 2015

I like that solution a lot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants