Add queryAll/getAll methods

[alexkrolick]

What:

Adds "all" methods for:

• byAltText
• byTestId

Why:

#27

How:

Checklist:

• Documentation
• Tests
• Ready to be merged
• Added myself to contributors table

---

Sidenote

If these getAll methods are added, the queryBy methods seem kind of redundant - instead of checking if queryBy returns null, you can check if getAll is [].

[kentcdodds]

I'm thinking that it would be good to actually have an *All* version for every query/get method for consistency.

And I'm thinking that we could probably have the *All* methods be the base and the existing methods just use those and return the first element to simplify the implementation.

What do you think?

Also, we'll want to make sure to document the existence of the *All* methods.

[alexkrolick]

I'm thinking that it would be good to actually have an All version for every query/get method for consistency.

Yep, just wanted to start with a few cases for review.

And I'm thinking that we could probably have the All methods be the base and the existing methods just use those and return the first element to simplify the implementation.

Yeah. Would the queryBy methods continue to be supported (ie if (result.length === 0) return null) or phased out?

Also, we'll want to make sure to document the existence of the All methods.

Yep.

Also, CI failed. Should I go for 100% branch coverage?

[kentcdodds]

Yes, let's do this with no breaking changes.

Yes, please maintain 100% code coverage 👍

[alexkrolick]

OK, 🍏

• Added queryAll methods for everything
• Reimplemented query APIs using queryAll
• Aliased getAll to queryAll (they are the same)
• Added tests for the array methods; most of the code is actually executed in tests for the get methods.
• Added docs

[kentcdodds]

I didn't have time to review everything, but I think we want the getAll* APIs to throw an error if there are no matching elements.

[alexkrolick]

✅ Changed getAll to throw the same errors as the get methods

[kentcdodds]

What if instead of creating these error functions we had the getBy* functions use the getAllBy* functions? Perhaps using firstResultOrNull.

Sorry, I still haven't reviewed all the PR but this is just something else I noticed.

[alexkrolick]

Yep that makes sense!

[kentcdodds]

Wow, this is so good. Thank you so much for the contribution! 🎉

[kentcdodds]

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

[kentcdodds]

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀