Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

Regex flag fix #161

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Regex flag fix #161

merged 2 commits into from
Dec 21, 2017

Conversation

NicoZelaya
Copy link
Contributor

@NicoZelaya NicoZelaya commented Dec 21, 2017

What: Changing constant regex creation.

Why: This causes issues on some versions of Node. Currently there are two issues opened for this.

How: Instead of using RegEx constructor, use RegEx literal. As the regex is constant there is no need to use the constructor.

Checklist:

  • Documentation "N/A"
  • Tests "N/A" (No need for update, but I've executed the test suite)
  • Ready to be merged
  • Added myself to contributors table

This is causing issues for us as well. It's just a small change that will increase compatibility.
Current issues that should be fixed with this:
#159
#160

Any feedback is really appreciated!

@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #161   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          63     63           
  Branches       14     14           
=====================================
  Hits           63     63
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa5c08...0fc3c36. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 3cf4170 into kentcdodds:master Dec 21, 2017
@NicoZelaya
Copy link
Contributor Author

You're welcome! It's a pleasure to be able to contribute.

This was referenced Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants