diff --git a/src/librustc_typeck/check/method/suggest.rs b/src/librustc_typeck/check/method/suggest.rs index 35d237d94de82..68c71f4ce90e9 100644 --- a/src/librustc_typeck/check/method/suggest.rs +++ b/src/librustc_typeck/check/method/suggest.rs @@ -245,12 +245,11 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> { "f32" }; match expr.node { - hir::ExprLit(_) => { // numeric literal - let snippet = tcx.sess.codemap().span_to_snippet(expr.span) + hir::ExprLit(ref lit) => { // numeric literal + let snippet = tcx.sess.codemap().span_to_snippet(lit.span) .unwrap_or("".to_string()); - // FIXME: use the literal for missing snippet - err.span_suggestion(expr.span, + err.span_suggestion(lit.span, &format!("you must specify a concrete type for \ this numeric value, like `{}`", concrete_type), diff --git a/src/test/ui/issue-51874.rs b/src/test/ui/issue-51874.rs new file mode 100644 index 0000000000000..63425274d4c49 --- /dev/null +++ b/src/test/ui/issue-51874.rs @@ -0,0 +1,13 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +fn main() { + let a = (1.0).pow(1.0); //~ ERROR can't call method `pow` on ambiguous numeric type +} diff --git a/src/test/ui/issue-51874.stderr b/src/test/ui/issue-51874.stderr new file mode 100644 index 0000000000000..8674645357189 --- /dev/null +++ b/src/test/ui/issue-51874.stderr @@ -0,0 +1,13 @@ +error[E0689]: can't call method `pow` on ambiguous numeric type `{float}` + --> $DIR/issue-51874.rs:12:19 + | +LL | let a = (1.0).pow(1.0); //~ ERROR can't call method `pow` on ambiguous numeric type + | ^^^ +help: you must specify a concrete type for this numeric value, like `f32` + | +LL | let a = (1.0_f32).pow(1.0); //~ ERROR can't call method `pow` on ambiguous numeric type + | ^^^^^^^ + +error: aborting due to previous error + +For more information about this error, try `rustc --explain E0689`.