You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When adding locations or hints that contain the values ( or ), in any combination, have the potential to break how data is stored for these fields.
To Reproduce
Steps to reproduce the behavior:
Submit a foundLocation with a ( or pair (...)
Submit a hint with a ( or pair (...)
Observe the data lost within the hint and foundLocation fields
Expected behavior
For these characters to not break the fields when included.
Screenshots
Additional context
I think it would be possible to improve the regular expressions that the biketag-api uses to be able to support parenthesis within the hint/foundLocation. If someone wants to help with this, you can look at the regular expressions that take this information and put it into/pull it from the singular title or description fields.
Describe the bug
When adding locations or hints that contain the values
(
or)
, in any combination, have the potential to break how data is stored for these fields.To Reproduce
Steps to reproduce the behavior:
(
or pair(...)
(
or pair(...)
Expected behavior
For these characters to not break the fields when included.
Screenshots
Additional context
I think it would be possible to improve the regular expressions that the biketag-api uses to be able to support parenthesis within the hint/foundLocation. If someone wants to help with this, you can look at the regular expressions that take this information and put it into/pull it from the singular title or description fields.
biketag-api/src/common/expressions.ts
Line 28 in 0053c3a
Used here:
biketag-api/src/imgur/helpers.ts
Line 454 in 0053c3a
And here is where the found description is built (using the
foundLocation
field):biketag-api/src/common/getters.ts
Line 453 in 0053c3a
And here is where the mystery description is built (using the
hint
field):https://github.com/KenEucker/biketag-api/blob/0053c3aea51dee8c3d79a9e557323d595fcaa449/src/common/getters.ts#L485C14-L485C55
The text was updated successfully, but these errors were encountered: