Introduce track_caller for panicing methods of ExecuteKernel #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* https://doc.rust-lang.org/stable/reference/attributes/codegen.html?highlight=track_call#the-track_caller-attribute * for future reference, if any path in the library panics all that needs to be done for the panic to show the location in the users code is mark all functions along the call-stack with track_caller * I did try and test the behavior, because I can be masocistic like that, but decided to give up on it, I would have to manually temporarily switch the panic_hook during testing, if that even works. Ugly, and if it happens to work its not guaranteed to continue working.
kenba
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds track_caller attributes to improve debugging for library users, as suggested in #49.
I did test it in my own project, worked as expected, for both the panic! and also the assert! calls.