Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return UUID as array #18

Closed
vmx opened this issue Jun 28, 2021 · 2 comments · Fixed by #19
Closed

Return UUID as array #18

vmx opened this issue Jun 28, 2021 · 2 comments · Fixed by #19
Assignees
Labels
enhancement New feature or request

Comments

@vmx
Copy link
Contributor

vmx commented Jun 28, 2021

The UUID related calls return a fixed sized array. It might make sense to return arrays of those instead of vectors.

I don't have a strong opinion on that, I just thought I bring it up, while I'm working with those function calls. In my code, where I use the uuid_khr(), I convert it into an array, so I thought It would be nice if it was already an array.

@vmx
Copy link
Contributor Author

vmx commented Jun 28, 2021

Related to this (let me know if I should open a separate issue). It would be great if cl3::ffi::cl_ext::CL_UUID_SIZE_KHR could be re-exported into opencl3, so that I can create such a fixed sized array without importing cl3.

@kenba
Copy link
Owner

kenba commented Jun 29, 2021

Hi Volker, my opinion on the UUID related calls is that they are just defined in an extension at the moment and it's possible to access the data using the device functions as you have done.

It may be nice to convert UUIDs to arrays now. However, it may be even nicer to convert them into UUIDs from the uuid crate. Or, in the future, when 128 bit integers are likely to be available in rust it wouldn't be so nice. So I'd rather not make that change at the moment.

I'm happy for cl3::ffi::cl_ext::CL_UUID_SIZE_KHR to be into opencl3. Would you like to submit a PR?

@kenba kenba added the enhancement New feature or request label Jun 29, 2021
@kenba kenba linked a pull request Jun 30, 2021 that will close this issue
@kenba kenba closed this as completed in b6b89a1 Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants