Skip to content

Commit

Permalink
fix(deps): update dependency luxon to v3.3.0 & add @types/luxon (#689)
Browse files Browse the repository at this point in the history
## Description
- added `@types/luxon` to dependencies
- updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types
aren't available for that version yet).

## Related Issue
Fixes #688.

## Motivation and Context
This library needs to depend on `@types/luxon` since we now export our
own types. See the related issue for the error this fixes.

## How Has This Been Tested?
- checked that TypeScript now correctly loads the Luxon types
- ran tests locally

## Types of changes
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
- [X] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [X] All new and existing tests passed.
- [ ] If my change introduces a breaking change, I have added a `!`
after the type/scope in the title (see the Conventional Commits
standard).
  • Loading branch information
sheerlox committed Aug 26, 2023
1 parent a09b521 commit c95a449
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 5 deletions.
22 changes: 18 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
},
"types": "types/index.d.ts",
"dependencies": {
"luxon": "^3.2.1"
"@types/luxon": "~3.3.0",
"luxon": "~3.3.0"
},
"devDependencies": {
"@commitlint/cli": "~17.6.6",
Expand Down

0 comments on commit c95a449

Please sign in to comment.