✨Ask user for a link to contributing guide (fixes #168) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kefranabg
reviewed
Nov 12, 2019
kefranabg
reviewed
Nov 12, 2019
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
Hi @kefranabg ! Thank you for the compliment. I have one silly request. Can you please add me to the all-contributors list for tests and bug reports as well? 😀 |
|
Sure! @all-contributors please add @anku255 for test,bug |
|
@all-contributors please add @anku255 for test |
|
I've put up a pull request to add @anku255! 🎉 |
|
@all-contributors please add @anku255 for bug |
|
I've updated the pull request to add @anku255! 🎉 |
kefranabg
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR fixes #168
I had to rename
contributingUrltoissuesUrlfirst and then I usedcontributingUrlfor the contributing guide link.Please take a look and suggest any changes if required. Thank you 🙂