-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalize the H in GitHub #116
Conversation
Apologies for open a tedious PR, but I stumbled on to this project after seeing the maintainer tweet out this getting added to the GitHub Package Registry. Per the GitHub design guidelines, the "H" should always be capitalized. Thanks for sharing and maintaing this project!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bdougie,
You're totally right ! Nice catch 👍
An update is missing in the test src/questions/author-github.spec.js
and it will be ok.
I'm glad this project helped you 😉
@all-contributors please add bdougie for code |
I've put up a pull request to add @bdougie! 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 196 196
Branches 21 21
=====================================
Hits 196 196
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 💪 Thanks again !
Apologies for open a tedious PR, but I stumbled on to this project after seeing the maintainer tweet out this getting added to the GitHub Package Registry.
Per the GitHub design guidelines, the "H" should always be capitalized.
Thanks for sharing and maintaining this project! Already using it in https://github.com/bdougie/theWeekNum.