Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize the H in GitHub #116

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Capitalize the H in GitHub #116

merged 2 commits into from
Sep 12, 2019

Conversation

bdougie
Copy link
Contributor

@bdougie bdougie commented Sep 12, 2019

Apologies for open a tedious PR, but I stumbled on to this project after seeing the maintainer tweet out this getting added to the GitHub Package Registry.

Per the GitHub design guidelines, the "H" should always be capitalized.

Thanks for sharing and maintaining this project! Already using it in https://github.com/bdougie/theWeekNum.

Apologies for open a tedious PR, but I stumbled on to this project after seeing the maintainer tweet out this getting added to the GitHub Package Registry. 

Per the GitHub design guidelines, the "H" should always be capitalized. 

Thanks for sharing and maintaing this project!
@bdougie bdougie changed the title Capitalize the H Capitalize the H in GitHub Sep 12, 2019
Copy link
Owner

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bdougie,

You're totally right ! Nice catch 👍
An update is missing in the test src/questions/author-github.spec.js and it will be ok.

I'm glad this project helped you 😉

@kefranabg
Copy link
Owner

@all-contributors please add bdougie for code

@allcontributors
Copy link
Contributor

@kefranabg

I've put up a pull request to add @bdougie! 🎉

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #116   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         196    196           
  Branches       21     21           
=====================================
  Hits          196    196
Impacted Files Coverage Δ
src/questions/author-github.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1fb5a...4315932. Read the comment docs.

Copy link
Owner

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💪 Thanks again !

@kefranabg kefranabg merged commit 3d08a76 into kefranabg:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants