Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Implement P2MS tests / features #248

Open
b-j-roberts opened this issue Oct 4, 2024 · 5 comments · May be fixed by #257
Open

[feat] Implement P2MS tests / features #248

b-j-roberts opened this issue Oct 4, 2024 · 5 comments · May be fixed by #257
Assignees
@supreme2580
Labels
enhancement New feature or request large/difficult issue

Comments

@b-j-roberts
Copy link
Contributor

Bitcoin has many different transaction types, one of them being P2MS.

In order to support these, we will need to make sure all edge cases and some mainnet P2MS transactions can successfully be validated by Shinigami.

The learnmeabitcoin link can be super helpful in understanding Bitcoin P2MS transactions in depth.

Then, using the learnmeabitcoin P2MS examples and existing Shinigami transaction tests, create a set of tests to ensure all P2MS transactions run properly.

Resources

learnmeabitcoin P2MS
Existing P2PK & P2PKH tests in Shinigami
@mubarak23
Copy link
Contributor

mubarak23 commented Oct 4, 2024 •
edited
Loading

@b-j-roberts can I take this

@mubarak23
Copy link
Contributor

@b-j-roberts am still available to work on this

@bloomingpeach
Copy link
Contributor

@b-j-roberts May I work on this?

@manlikeHB
Copy link
Contributor

Hi @b-j-roberts, can i work on this?

@supreme2580
Copy link
Contributor

Hi @b-j-roberts can I be assigned to this?

@supreme2580 supreme2580 linked a pull request Oct 10, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supreme2580 supreme2580

Labels
enhancement New feature or request large/difficult issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented tests and validation for P2MS supreme2580/shinigami
5 participants
@mubarak23 @b-j-roberts @supreme2580 @manlikeHB @bloomingpeach