You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
The RPC route estimate_fee receives a vec of tx to estimate.
We spawn one instance of the runtime for each tx.
This means that the state is reset between each estimated transaction.
Expected behavior:
The state should not reset. Tx number n should be executed on a state changed by tx number n-1
Steps to reproduce:
Call estimate fee with multiple tx from the same account, while increasing the nonce for each tx.
It will fail because the second will have nonce = 1 when the runtime expect nonce = 0.
Related code:
the loop in crates/client/rpc/src/lib.rs, fn estimate_fee: for tx in request {...} should happen inside crates/pallets/starknet/src/lib.rs, fn estimate_fee.
Bug Report
Madara version: 0.4.0
Current behavior:
The RPC route estimate_fee receives a vec of tx to estimate.
We spawn one instance of the runtime for each tx.
This means that the state is reset between each estimated transaction.
Expected behavior:
The state should not reset. Tx number n should be executed on a state changed by tx number n-1
Steps to reproduce:
Call estimate fee with multiple tx from the same account, while increasing the nonce for each tx.
It will fail because the second will have nonce = 1 when the runtime expect nonce = 0.
Related code:
the loop in crates/client/rpc/src/lib.rs, fn estimate_fee:
for tx in request {...}
should happen inside crates/pallets/starknet/src/lib.rs, fn estimate_fee.it's signature should be changed to:
Other information:
The text was updated successfully, but these errors were encountered: