Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dialog component #126

Closed
ugur-eren opened this issue May 28, 2024 · 2 comments · Fixed by #144
Closed

Create Dialog component #126

ugur-eren opened this issue May 28, 2024 · 2 comments · Fixed by #144
Assignees
Labels

Comments

@ugur-eren
Copy link
Collaborator

ugur-eren commented May 28, 2024

OD Hack

This issue is part of ODHack 4.0:

description - https://x.com/OnlyDust_com/status/1791035111992934563
guidelines - https://onlydust.notion.site/ODHack-Common-Guidelines-Project-leads-5e21836f85ad493f9ca429770af0ad40

Please read the guidelines and make sure you follow them.

Please write your thoughts and how long you think it will take to complete the issue in the comments.

Dialog component

We need to have a Dialog component to replace alerts. The design for Dialog component is available at Figma: https://www.figma.com/design/NIJ68MV1AeI8y283woXiM0/JoyBoy?node-id=482-13792&t=V6IQaFPV2PwAn7U5-0

For easier development, Dialog component should at least have these props:

  • icon: React.ReactNode
  • title: string
  • description: string
  • buttons: {label: string; type: dangerous | primary | secondary; onPress: () => void}[]

Dialog component should use Portal component from react-native-portalize library to render the dialog in front of other content.

You should implement the design as close as possible and should match 1:1.

Please battle test it before doing a PR.

Communication

https://t.me/JoyboyStarknet/949

May the Joy be with you!

@josephchimebuka
Copy link
Contributor

josephchimebuka commented May 28, 2024

I would like to handle this @ugur-eren

@addegbenga
Copy link

i will love to work on this

This was linked to pull requests May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants