Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Github webhook secret #534

Open
shinebayar-g opened this issue Aug 30, 2020 · 2 comments
Open

Support Github webhook secret #534

shinebayar-g opened this issue Aug 30, 2020 · 2 comments

Comments

@shinebayar-g
Copy link

shinebayar-g commented Aug 30, 2020

Hi, is the Github webhook secret supported? I didn't find anything in docs. If not, is it possible to support the Github webhook secrets?

@rusenask
Copy link
Collaborator

rusenask commented Sep 1, 2020

Not supported but seems straightforward to add. Need to add a check here https://github.com/keel-hq/keel/blob/master/pkg/http/github_webhook_trigger.go#L233 where we get request bytes. They have instructions for ruby (https://docs.github.com/en/developers/webhooks-and-events/securing-your-webhooks#validating-payloads-from-github) but Go's std lib provides sha1 digest check as well.

@shinebayar-g
Copy link
Author

Looks like Github is introducing new docker registry because of current one doesn't even allow pull public images without logging into github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants