From d02a5996ea8c2ee8458cb2bfb837762bd019d822 Mon Sep 17 00:00:00 2001 From: Tomek Urbaszek Date: Sat, 25 Jan 2020 17:47:03 +0100 Subject: [PATCH 1/3] Improve README --- README.md | 60 ++++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/README.md b/README.md index 05e10a4facb..776df58bbd7 100644 --- a/README.md +++ b/README.md @@ -5,9 +5,12 @@ nightly e2e Twitter

-KEDA allows for fine grained autoscaling (including to/from zero) for event driven Kubernetes workloads. KEDA serves as a Kubernetes Metrics Server and allows users to define autoscaling rules using a dedicated Kubernetes custom resource definition. +KEDA allows for fine grained autoscaling (including to/from zero) for event driven Kubernetes workloads. KEDA serves +as a Kubernetes Metrics Server and allows users to define autoscaling rules using a dedicated Kubernetes custom +resource definition. -KEDA can run on both the cloud and the edge, integrates natively with Kubernetes components such as the Horizontal Pod Autoscaler, and has no external dependencies. +KEDA can run on both the cloud and the edge, integrates natively with Kubernetes components such as the Horizontal +Pod Autoscaler, and has no external dependencies. ---

@@ -15,10 +18,10 @@ In partnership with

-

+

--- - + ## Getting started * [QuickStart - RabbitMQ and Go](https://github.com/kedacore/sample-go-rabbitmq) @@ -39,7 +42,7 @@ You can find a [FAQ here](https://keda.sh/faq/) with some common questions. ## Samples -You can find several samples for various event sources [here](https://github.com/kedacore/samples) +You can find several samples for various event sources [here](https://github.com/kedacore/samples). ## Community @@ -49,15 +52,18 @@ If interested in contributing or participating in the direction of KEDA, you can * **Zoom link:** [https://zoom.us/j/150360492 ](https://zoom.us/j/150360492 ) * **Meeting agenda:** [https://hackmd.io/s/r127ErYiN](https://hackmd.io/s/r127ErYiN) -Just want to learn or chat about KEDA? Feel free to join the conversation in **[#KEDA](kubernetes.slack.com/messages/CKZJ36A5D)** on the **[Kubernetes Slack](https://slack.k8s.io/)**! +Just want to learn or chat about KEDA? Feel free to join the conversation in +**[#KEDA](kubernetes.slack.com/messages/CKZJ36A5D)** on the **[Kubernetes Slack](https://slack.k8s.io/)**! ## Building: Quick start with [Visual Studio Code Remote - Containers](https://code.visualstudio.com/docs/remote/containers) -This helps you pull and build quickly - dev containers launch the project inside a container with all the tooling required for a consistent and seamless developer experience. +This helps you pull and build quickly - dev containers launch the project inside a container with all the tooling +required for a consistent and seamless developer experience. This means you don't have to install and configure your dev environment as the container handles this for you. -To get started install [VSCode](https://code.visualstudio.com/) and the [Remote Containers extensions](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) +To get started install [VSCode](https://code.visualstudio.com/) and the [Remote Containers extensions]( +https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) Clone the repo and launch code: @@ -67,16 +73,20 @@ cd keda code . ``` -Once VSCode launches run `CTRL+SHIFT+P -> Remote-Containers: Reopen in container` and then use the integrated terminal to run: +Once VSCode launches run `CTRL+SHIFT+P -> Remote-Containers: Reopen in container` and then use the integrated +terminal to run: ```bash make build ``` -> Note: The first time you run the container it will take some time to build and install the tooling. The image will be cached so this is only required the first time. +> Note: The first time you run the container it will take some time to build and install the tooling. The image +> will be cached so this is only required the first time. ## Building: Locally directly -This project is using [Operator SDK framework](https://github.com/operator-framework/operator-sdk), make sure you have installed the right version. To check the current version used for KEDA check the `RELEASE_VERSION` in file [tools/build-tools.Dockerfile](https://github.com/kedacore/keda/blob/master/tools/build-tools.Dockerfile). +This project is using [Operator SDK framework](https://github.com/operator-framework/operator-sdk), make sure you +have installed the right version. To check the current version used for KEDA check the `RELEASE_VERSION` in file +[tools/build-tools.Dockerfile](https://github.com/kedacore/keda/blob/master/tools/build-tools.Dockerfile). ```bash git clone git@github.com:kedacore/keda.git @@ -86,19 +96,33 @@ make build ## Deploying Custom KEDA -If you want to change KEDA's behaviour, or if you have created a new scaler (more docs on this to come) and you want to deploy it as part of KEDA. Do the following: +If you want to change KEDA's behaviour, or if you have created a new scaler (more docs on this to come) and you want +to deploy it as part of KEDA. Do the following: + 1. Make your change in the code. -2. In terminal, create an environment variable `IMAGE_TAG` and assign it a value for your preference, this tag will be used when creating the operator image that will run KEDA. -***Note***: make sure it doesn't clash with the official tags of KEDA containers in DockerHub. -3. Still in terminal, run `make build` at the root of the source code. This will also build the docker image for the KEDA operator that you can deploy to your local cluster. This should build 2 docker images: `kedacore/keda` and `kedacore/keda-metrics-adapter` tagged with the tag you set in step 2 +2. In terminal, create an environment variable `IMAGE_TAG` and assign it a value for your preference, this tag will + be used when creating the operator image that will run KEDA. + + ***Note***: make sure it doesn't clash with the official tags of KEDA containers in DockerHub. +3. Still in terminal, run `make build` at the root of the source code. This will also build the docker image for + the KEDA operator that you can deploy to your local cluster. This should build 2 docker images: `kedacore/keda` + and `kedacore/keda-metrics-adapter` tagged with the tag you set in step 2 4. If you haven't downloaded them before, clone the charts repository: `git clone git@github.com:kedacore/charts.git` -5. Still in terminal, navigate to the `chart/keda` folder (downlodaed in step 4), and run the following command (don't forget to replace the placeholder text in the command) `helm install . --set image.keda=kedacore/keda:$IMAGE_TAG,image.metricsAdapter=kedacore/keda-metrics-adapter:$IMAGE_TAG,image.pullPolicy=IfNotPresent`. This will use the images built at step 3. Notice the need to override the image pullPolicy to `IfNotPresent` in order to use the locally built images and not try to pull the images from remote repo on Docker Hub (and complain about not finding them). -6. Once the keda operator pod is up, check the logs of both containers to verify everything running ok, eg: `kubectl logs -c keda-operator-metrics-apiserver` and `kubectl logs -c keda-operator` +5. Still in terminal, navigate to the `charts/keda` folder (downlodaed in step 4), and run the following command + (don't forget to replace the placeholder text in the command): + ```bash + helm install . --set image.keda=kedacore/keda:$IMAGE_TAG,image.metricsAdapter=kedacore/keda-metrics-adapter:$IMAGE_TAG,image.pullPolicy=IfNotPresent` + ``` + This will use the images built at step 3. Notice the need to override the image pullPolicy to `IfNotPresent` in + order to use the locally built images and not try to pull the images from remote repo on Docker Hub (and complain + about not finding them). +6. Once the keda operator pod is up, check the logs of both containers to verify everything running ok, eg: +`kubectl logs -c keda-operator-metrics-apiserver` and `kubectl logs -c keda-operator` # Contributing -This project welcomes contributions and suggestions. Most contributions require you to agree to a +This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.microsoft.com. From 339251fcced45a66e90468b793a5455f6e00fb07 Mon Sep 17 00:00:00 2001 From: Tomek Urbaszek Date: Sat, 25 Jan 2020 22:48:29 +0100 Subject: [PATCH 2/3] fixup! Improve README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 776df58bbd7..f40d5b00e9a 100644 --- a/README.md +++ b/README.md @@ -108,7 +108,7 @@ to deploy it as part of KEDA. Do the following: the KEDA operator that you can deploy to your local cluster. This should build 2 docker images: `kedacore/keda` and `kedacore/keda-metrics-adapter` tagged with the tag you set in step 2 4. If you haven't downloaded them before, clone the charts repository: `git clone git@github.com:kedacore/charts.git` -5. Still in terminal, navigate to the `charts/keda` folder (downlodaed in step 4), and run the following command +5. Still in terminal, navigate to the `charts/keda` folder (downloaded in step 4), and run the following command (don't forget to replace the placeholder text in the command): ```bash helm install . --set image.keda=kedacore/keda:$IMAGE_TAG,image.metricsAdapter=kedacore/keda-metrics-adapter:$IMAGE_TAG,image.pullPolicy=IfNotPresent` From c104a0b70f6333f4cb2f74554b861c824b57c8a1 Mon Sep 17 00:00:00 2001 From: Tomek Urbaszek Date: Mon, 27 Jan 2020 09:12:40 +0100 Subject: [PATCH 3/3] fixup! fixup! Improve README --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index f40d5b00e9a..12b961f89e9 100644 --- a/README.md +++ b/README.md @@ -102,7 +102,6 @@ to deploy it as part of KEDA. Do the following: 1. Make your change in the code. 2. In terminal, create an environment variable `IMAGE_TAG` and assign it a value for your preference, this tag will be used when creating the operator image that will run KEDA. - ***Note***: make sure it doesn't clash with the official tags of KEDA containers in DockerHub. 3. Still in terminal, run `make build` at the root of the source code. This will also build the docker image for the KEDA operator that you can deploy to your local cluster. This should build 2 docker images: `kedacore/keda`