From 0cda3ff60d202688315cf9defe8a59e17b573357 Mon Sep 17 00:00:00 2001 From: Jorge Turrado Ferrero Date: Sat, 20 Nov 2021 18:27:17 +0100 Subject: [PATCH 1/4] Update pr-e2e workflow to edit the trigger comment with the url Signed-off-by: jorturfer --- .github/workflows/pr-e2e.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pr-e2e.yml b/.github/workflows/pr-e2e.yml index 41c5af04911..9ba5e91855b 100644 --- a/.github/workflows/pr-e2e.yml +++ b/.github/workflows/pr-e2e.yml @@ -26,14 +26,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: React to comment with rocket - uses: dkershner6/reaction-action@v1 - if: steps.check-comment.outputs.triggered == 'true' && steps.check-permission.outputs.has-permission - with: - token: ${{ secrets.GITHUB_TOKEN }} - commentId: ${{ github.event.comment.id }} - reaction: "rocket" - run-test: needs: check runs-on: ubuntu-latest @@ -44,6 +36,14 @@ jobs: steps: - uses: actions/checkout@v2 + - name: Update comment with the execution url + uses: peter-evans/create-or-update-comment@v1 + with: + comment-id: ${{ github.event.comment.id }} + body: | + **Update:** You can check the progres [here](https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}) + reactions: rocket + - name: Checkout Pull Request env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 00c644ef40663576c2aa1db1870abef97797560a Mon Sep 17 00:00:00 2001 From: jorturfer Date: Sat, 20 Nov 2021 18:35:19 +0100 Subject: [PATCH 2/4] Update changelog Signed-off-by: jorturfer --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 050667a147a..670e4c9eeed 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,6 +74,7 @@ - Add Makefile mockgen targets ([#2090](https://github.com/kedacore/keda/issues/2090)|[#2184](https://github.com/kedacore/keda/pull/2184)) - Drop support to `ValueMetricType` using cpu_memory_scaler ([#2218](https://github.com/kedacore/keda/issues/2218)) - Add github action to run e2e command "on-demand" ([#2241](https://github.com/kedacore/keda/issues/2241)) +- Add execution url in the pr-e2e triggering comment ([#2306](https://github.com/kedacore/keda/issues/2306)) ## v2.4.0 From ea888f8b7b601d68ab4c23e08457faf4e1041d92 Mon Sep 17 00:00:00 2001 From: Jorge Turrado Date: Mon, 22 Nov 2021 12:08:20 +0100 Subject: [PATCH 3/4] Replaces khan/pull-request-comment-trigger with inline functions Signed-off-by: Jorge Turrado --- .github/workflows/pr-e2e.yml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/pr-e2e.yml b/.github/workflows/pr-e2e.yml index 9ba5e91855b..9a86e2e84f0 100644 --- a/.github/workflows/pr-e2e.yml +++ b/.github/workflows/pr-e2e.yml @@ -7,18 +7,10 @@ jobs: runs-on: ubuntu-latest name: Comment evaluate outputs: - run-e2e: ${{ steps.check-comment.outputs.triggered == 'true' && steps.check-permission.outputs.has-permission }} + run-e2e: ${{ startsWith(github.event.comment.body,'/run-e2e') && steps.check-permission.outputs.has-permission }} steps: - - uses: khan/pull-request-comment-trigger@master - id: check-comment - with: - trigger: '/run-e2e' - prefix_only: true - env: - GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}' - - name: Check user permission - if: steps.check-comment.outputs.triggered == 'true' + if: startsWith(github.event.comment.body,'/run-e2e') id: check-permission uses: scherermichael-oss/action-has-permission@master with: From 9630b7359e26d777abfbbb4de30750b02d967a18 Mon Sep 17 00:00:00 2001 From: Jorge Turrado Date: Mon, 22 Nov 2021 12:15:39 +0100 Subject: [PATCH 4/4] Update changelog Signed-off-by: Jorge Turrado --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 670e4c9eeed..543446eceb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,7 +74,7 @@ - Add Makefile mockgen targets ([#2090](https://github.com/kedacore/keda/issues/2090)|[#2184](https://github.com/kedacore/keda/pull/2184)) - Drop support to `ValueMetricType` using cpu_memory_scaler ([#2218](https://github.com/kedacore/keda/issues/2218)) - Add github action to run e2e command "on-demand" ([#2241](https://github.com/kedacore/keda/issues/2241)) -- Add execution url in the pr-e2e triggering comment ([#2306](https://github.com/kedacore/keda/issues/2306)) +- Add execution url in the pr-e2e triggering comment and fix problem related with not starting with ([#2306](https://github.com/kedacore/keda/issues/2306)) ## v2.4.0