Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for gRPC requests between metrics-api-server and operator #5502

Closed
aliaqel-stripe opened this issue Feb 13, 2024 · 1 comment · Fixed by kedacore/keda-docs#1340 or #5615
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@aliaqel-stripe
Copy link
Contributor

aliaqel-stripe commented Feb 13, 2024

Proposal

For observability reasons, it would be nice to have metrics exposed to report on success/failure of gRPC requests between the metrics-api-server and operator.

Use-Case

We'd like to alert when theres a drop in the success rate in the gRPC requests, and we'd like to observe from the perspective of both the client and the server.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

Slack thread: https://kubernetes.slack.com/archives/CKZJ36A5D/p1707521775263629

@aliaqel-stripe aliaqel-stripe added feature-request All issues for new features that have not been committed to needs-discussion labels Feb 13, 2024
@aliaqel-stripe
Copy link
Contributor Author

FYI, incorrectly marked that I wasn't interested in making this change. I'm planning on making this change myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
1 participant