From 4cfbde29dfd6b12d9409c3991f3cf74dbfa196d6 Mon Sep 17 00:00:00 2001 From: Ang Gao Date: Wed, 24 Mar 2021 11:23:21 +0000 Subject: [PATCH] add comments --- Makefile | 4 ++++ config/default/kustomization.yaml | 2 ++ 2 files changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 0b292a13e86..6e0adcf63df 100644 --- a/Makefile +++ b/Makefile @@ -88,6 +88,8 @@ release: manifests kustomize set-version $(KUSTOMIZE) edit set image ghcr.io/kedacore/keda=${IMAGE_CONTROLLER} cd config/metrics-server && \ $(KUSTOMIZE) edit set image ghcr.io/kedacore/keda-metrics-apiserver=${IMAGE_ADAPTER} + # Need this workaround to mitigate a problem with inserting labels into selectors, + # until this issue is solved: https://github.com/kubernetes-sigs/kustomize/issues/1009 @sed -i".out" -e 's@version:[ ].*@version: $(VERSION)@g' config/default/kustomize-config/metadataLabelTransformer.yaml rm -rf config/default/kustomize-config/metadataLabelTransformer.yaml.out $(KUSTOMIZE) build config/default > keda-$(VERSION).yaml @@ -122,6 +124,8 @@ deploy: manifests kustomize $(KUSTOMIZE) edit set image ghcr.io/kedacore/keda=${IMAGE_CONTROLLER} cd config/metrics-server && \ $(KUSTOMIZE) edit set image ghcr.io/kedacore/keda-metrics-apiserver=${IMAGE_ADAPTER} + # Need this workaround to mitigate a problem with inserting labels into selectors, + # until this issue is solved: https://github.com/kubernetes-sigs/kustomize/issues/1009 @sed -i".out" -e 's@version:[ ].*@version: $(VERSION)@g' config/default/kustomize-config/metadataLabelTransformer.yaml rm -rf config/default/kustomize-config/metadataLabelTransformer.yaml.out $(KUSTOMIZE) build config/default | kubectl apply -f - diff --git a/config/default/kustomization.yaml b/config/default/kustomization.yaml index 4ae134fe5c2..78785e88d6d 100644 --- a/config/default/kustomization.yaml +++ b/config/default/kustomization.yaml @@ -19,6 +19,8 @@ apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization commonLabels: app.kubernetes.io/part-of: keda-operator +# Need this transformer to mitigate a problem with inserting labels into selectors, +# until this issue is solved: https://github.com/kubernetes-sigs/kustomize/issues/1009 transformers: - kustomize-config/metadataLabelTransformer.yaml