Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change page titles so that page-content title comes before the site title #678

Closed
chalin opened this issue Feb 22, 2022 · 4 comments · Fixed by #700
Closed

Change page titles so that page-content title comes before the site title #678

chalin opened this issue Feb 22, 2022 · 4 comments · Fixed by #700
Assignees
@chalin
Labels
enhancement New feature or request website

Comments

@chalin
Copy link
Contributor

chalin commented Feb 22, 2022

Currently page titles are of the form KEDA | <content-title>. It is more typical (and makes analytics analytics easier) if title has a format like <content-title> | KEDA.

Any objections to making this change @tomkerkhove et all?
@tomkerkhove tomkerkhove added this to the Documentation Improvements milestone Feb 23, 2022
@tomkerkhove tomkerkhove added the enhancement New feature or request label Feb 23, 2022
@tomkerkhove
Copy link
Member

@kedacore/keda-maintainers Any objections on this?

@tomkerkhove tomkerkhove changed the title Rework HTML titles so that page-content title comes before the site title Change page titles so that page-content title comes before the site title Feb 23, 2022
@zroubalik
Copy link
Member

+1

@tomkerkhove
Copy link
Member

Majority, let's do it @chalin!

@chalin
Copy link
Contributor Author

chalin commented Mar 4, 2022

/assign

@chalin chalin mentioned this issue Mar 4, 2022
Merged
@chalin chalin mentioned this issue Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
enhancement New feature or request website
Projects
Documentation Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make HTML titles consistent: "<page-title> | KEDA" chalin/keda-docs
3 participants
@zroubalik @chalin @tomkerkhove