Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated Color #3

Open
rwxguo opened this issue Aug 10, 2020 · 1 comment
Open

Duplicated Color #3

rwxguo opened this issue Aug 10, 2020 · 1 comment

Comments

@rwxguo
Copy link

rwxguo commented Aug 10, 2020

Current color palette is selected from 8 scopes name. The color may be duplicated in some color schemes. That makes highlighter confusing when each highlight use the same color in file. The issue caused by :

  1. Some scopes are not defined
  2. Some scopes are defined by the same color

To resolve this problem, it is suggested that when creating "colors_by_scope", do not add all scopes, instead, skip the scopes which color is the same as the scopes already inserted into "colors_by_scope" by comparing the color HEX.

Besides, please add more scopes into "colors_by_scope" to increase the number of highlight avaliable.

@kdnk
Copy link
Owner

kdnk commented Aug 30, 2020

Actually, I haven't been using Sublime Text much lately.
Can you create a PR, if you'd like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants