From 34e0dcf8833533ffe992b33637930fe909b2250f Mon Sep 17 00:00:00 2001 From: Joaquim Moreno Date: Thu, 10 Mar 2022 14:01:55 +0000 Subject: [PATCH] syncer/syncer.go: Add to default sync, serviceaccounts, secrets and configmaps. --- pkg/syncer/syncer.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/syncer/syncer.go b/pkg/syncer/syncer.go index e0f048af244..356e81593db 100644 --- a/pkg/syncer/syncer.go +++ b/pkg/syncer/syncer.go @@ -176,7 +176,9 @@ func getAllGVRs(discoveryClient discovery.DiscoveryInterface, resourcesToSync .. return nil, err } } - gvrstrs := []string{"namespaces.v1."} // A syncer should always watch namespaces + // TODO(jmprusi): Added ServiceAccounts, Configmaps and Secrets to the default syncing, but we should figure out + // a way to avoid doing that: https://github.com/kcp-dev/kcp/issues/727 + gvrstrs := []string{"namespaces.v1.", "serviceaccounts.v1.", "configmaps.v1.", "secrets.v1."} // A syncer should always watch namespaces, serviceaccounts, secrets and configmaps. for _, r := range rs { // v1 -> v1. // apps/v1 -> v1.apps