Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAQ] Keys with hyphens support in FAQ #143

Open
Peefy opened this issue Aug 23, 2023 · 6 comments
Open

[FAQ] Keys with hyphens support in FAQ #143

Peefy opened this issue Aug 23, 2023 · 6 comments
Labels
faq good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Peefy
Copy link
Contributor

Peefy commented Aug 23, 2023

Enhancement

kcl-lang/kcl#681

@Peefy Peefy added the faq label Aug 23, 2023
@YiuTerran
Copy link

Top-level keys still cannot contain hyphens, but this is allowed in yaml.

@Peefy
Copy link
Contributor Author

Peefy commented Jan 2, 2024

Top-level keys still cannot contain hyphens, but this is allowed in yaml.

Hi @YiuTerran, thank you for your feedback. Currently, KCL supports this for top level keys both in config and schema, for the following code.

schema Data:
    "a-b-c": str

Data {
    "a-b-c": "a-b-c"
}

Of course, it does have more room for evolution at the grammatical and semantic levels. 🤔️

@Peefy Peefy added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 2, 2024
@Peefy Peefy changed the title [FAQ] Keys with hyphens support [FAQ] Keys with hyphens support in FAQ Jan 2, 2024
@YiuTerran
Copy link

YiuTerran commented Jan 2, 2024

@Peefy The kpm import command is currently unable to handle this situation correctly.

@Peefy
Copy link
Contributor Author

Peefy commented Jan 2, 2024

@YiuTerran I see. Thank you for your feedback. I have opened an Issue for recording this: kcl-lang/kcl-go#204

The import related functions are currently implemented in kcl-lang/kcl-go. If you are interested, PRs welcome! Otherwise we will fix it before next week. Thank you again. ❤️

@d4v1d03
Copy link
Contributor

d4v1d03 commented Feb 23, 2024

Hey, @Peefy is this issue fixed?

@Peefy
Copy link
Contributor Author

Peefy commented Feb 23, 2024

Hey, @Peefy is this issue fixed?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
faq good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants