You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
Start application and log in / continue without log in.
Open a local or remote repository.
Modify the end of a file so that you get "No newline at end of file" in the diff panel.
Observe that the line number is duplicated, and the +/- column shows a '<' (or '=') symbol instead. The new line note also spans more than one line.
Actual behaviour:
Expected behaviour:
The new line note should either be removed, or formatted on one line such that the line number does not get duplicated.
Suggestions:
There is currently already a check for the new line note (checking for line.origin()!=62 in git.ts), but this does not seem to work consistently, so you may just need to add a few more checks for other variations of the line.
The text was updated successfully, but these errors were encountered:
ktam069
changed the title
No newline notes are formatted improperly in the diff panel
"No newline at end of file" notes are formatted improperly in the diff panel
Apr 12, 2019
Steps to reproduce:
Actual behaviour:
Expected behaviour:
The new line note should either be removed, or formatted on one line such that the line number does not get duplicated.
Suggestions:
There is currently already a check for the new line note (checking for line.origin()!=62 in git.ts), but this does not seem to work consistently, so you may just need to add a few more checks for other variations of the line.
The text was updated successfully, but these errors were encountered: