Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

"No newline at end of file" notes are formatted improperly in the diff panel #354

Open
ktam069 opened this issue Apr 12, 2019 · 1 comment

Comments

@ktam069
Copy link
Collaborator

ktam069 commented Apr 12, 2019

Steps to reproduce:

  1. Start application and log in / continue without log in.
  2. Open a local or remote repository.
  3. Modify the end of a file so that you get "No newline at end of file" in the diff panel.
  4. Observe that the line number is duplicated, and the +/- column shows a '<' (or '=') symbol instead. The new line note also spans more than one line.

Actual behaviour:
image

Expected behaviour:
The new line note should either be removed, or formatted on one line such that the line number does not get duplicated.

Suggestions:
There is currently already a check for the new line note (checking for line.origin()!=62 in git.ts), but this does not seem to work consistently, so you may just need to add a few more checks for other variations of the line.
image

@ktam069 ktam069 added the Small label Apr 12, 2019
@ktam069 ktam069 changed the title No newline notes are formatted improperly in the diff panel "No newline at end of file" notes are formatted improperly in the diff panel Apr 12, 2019
@0608jennylee
Copy link
Collaborator

approve

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants