Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with pjax and DataColumn #434

Closed
stepancher opened this issue Jan 12, 2016 · 9 comments
Closed

Bug with pjax and DataColumn #434

stepancher opened this issue Jan 12, 2016 · 9 comments
Labels

Comments

@stepancher
Copy link

If i don't use Pjax, i have error "Undefined index: options" in line 355 in DataColumn. Please add check in this file like this

      if (Config::isInputWidget($this->filterType) && $this->grid->pjax) {
                    $options['pjaxContainerId'] = $this->grid->pjaxSettings['options'][' 
      }
@Imam86
Copy link

Imam86 commented Jan 13, 2016

Yep. After updated through composer today, I got this error, too.
Thanks for the solution. So I changed DataColumn.php at line 354.

Before:

if (Config::isInputWidget($this->filterType)) {

After:

if (Config::isInputWidget($this->filterType) && $this->grid->pjax) {

And the error is gone.

@kartik-v kartik-v added the bug label Jan 13, 2016
@kartik-v
Copy link
Owner

Closed via update to release v3.1.0.

@enscope
Copy link

enscope commented Jan 18, 2016

When to expect 3.1.0 be available for composer? "at-dev" version (and composer packagist) both point to 3.0.9 as most recent version (with "~3.1" not available), which contains this bug. Thank you!

@unNene
Copy link

unNene commented Jan 24, 2016

@kartik-v please see DataColumn.php version 3.1.0, line 355.
https://github.com/kartik-v/yii2-grid/blob/8917f5729852770622ba9e2b92c141ac44b2413f/DataColumn.php

There is a error, you have to use $this->grid->pjax instead of $this->pjax

@kartik-v
Copy link
Owner

Duplicate to and fixed via #438.

@enscope
Copy link

enscope commented Jan 24, 2016

Is someone reading me here? What I was asking is, if there will be 3.1.0 published on packagist as well or we are stuck in using dev-master?

Ref: https://packagist.org/packages/kartik-v/yii2-grid

@dogrocker
Copy link
Contributor

Same as @enscope .
I stuck with 3.0.9 too got an error.

@kartik-v
Copy link
Owner

The response was for query by @unNene - the bug is already fixed in v3.1.0

@enscope @dogrocker in response to your query - the release v3.1.0 is not tagged yet and will be done a bit later after some tests.

@dogrocker
Copy link
Contributor

Thank you very much @kartik-v.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants