initPjax called multiple times

[ShadesOB]

initPjax (client side) gets run on grid refresh. Which results in duplicate "pjax:complete" events being bound to grid object.

You can probably think of a better way to fix this. But attached below is a possible fix.

Located in yii2-grid\ColumnTrait.php line 311

protected function initPjax($script = '')
    {

        if (!$this->grid->pjax || empty($script)) {
            return;
        }
        $scriptId = md5($script);

        $cont = 'jQuery("#' . $this->grid->pjaxSettings['options']['id'] . '")';
        $grid = $this->grid->options['id'];
        $view = $this->grid->getView();
        $view->registerJs(

            //Stops duplicate scripts running
            $cont.'.each(function(){
                if($(this).data("pjax:complete:'.$scriptId.'")){
                    return true;
                }
                '.$cont.'.data("pjax:complete:'.$scriptId.'",1);
                '.$cont.'.on("pjax:complete", function(){'.$script.'});
            });'
        );
    }

[kartik-v]

Resolved via latest fix. Made it a little simpler for validating this.

[ShadesOB]

This looks good.
Possible idea for future may be to bind these on initial page load and then never do it via pjax.
Pros: not sending unneeded js. No need to unbind \ rebind.
cons: if js changes it won't update till page reload - if current solution works, is it worth putting more time into it?

Also this is without going through any code to even see if it's possible.

Thanks for continued awesome work thought. :D

[kartik-v]

All of these are already initialized on page load. The problem is you are overwriting content via pjax which destroys the jquery elements and as a result all its event bindings. Hence this has to be parsed in something like pjax:complete (as is done now) to ensure the element exists for reinitializing.