Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to build on Windows #25

Closed
beta opened this issue Apr 24, 2019 · 1 comment · Fixed by #26
Closed

Failed to build on Windows #25

beta opened this issue Apr 24, 2019 · 1 comment · Fixed by #26
Assignees
@karrick
Labels
bug

Comments

@beta
Copy link
Contributor

beta commented Apr 24, 2019

When building the latest version (v1.8.1) on Windows, the following error occurred:

# github.com/karrick/godirwalk
..\Go\pkg\mod\github.com\karrick\godirwalk@v1.8.1\follow_windows.go:10:6: evalSymlinksHelper redeclared in this block
        previous declaration at ..\Go\pkg\mod\github.com\karrick\godirwalk@v1.8.1\follow_unix.go:4:51

IMHO _unix in filename is not supported, as per golang/go#20322. Should build tags be added for Unix platforms?
@beta beta mentioned this issue Apr 24, 2019
Merged
@karrick karrick self-assigned this Apr 24, 2019
@karrick
Copy link
Owner

karrick commented Apr 24, 2019

I am so sorry for that. I will get these fixed as soon as I can get to my Windows laptop.

@karrick karrick added the bug label Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karrick karrick

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Unix build tags
2 participants
@karrick @beta