-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request ownership of Safari launcher #589
Comments
This is already done, but not cleaned up or is there another repo then : https://github.com/karma-runner/karma-safari-launcher |
The npm page for karma-safari-launcher points to https://github.com/explicitcall/karma-safari-launcher not to https://github.com/karma-runner/karma-safari-launcher . |
Yep, I forgot to push it to NPM and in the meantime @explicitcall pushed his version, which is different than the original Safari launcher (it uses 'open' and therefore does never kill the browser - that's why I originally did the workaround with opening an html file). I contacted @explicticall twice per email, suggesting, we push the original launcher as "karma-safari-launcher" and refactor his version to general "open-launcher", that would just open the default OS browser. I never heard from him. |
Hi, just got this notification. The reason for a fork was karma 0.9 neither compatible with old safari-launcher nor providing its own new version. If you know how to remove npm package with original "karma-safari-launcher" name, just say how to do this. I'm not currently (and in the nearest future) working with anything related with karma, so you can do anything you want with my fork. |
@explicitcall The easiest thing is to just use npm-owner to give @vojtajina ownership on npm, then he can publish the new version :) |
done |
@explicitcall thanks! It's pushed to NPM. |
karma-runner should be the owner of the karma-safari-launcher.
The text was updated successfully, but these errors were encountered: