Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): temporarily disable strict parameters validation #3641

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

devoto13
Copy link
Collaborator

As discussed in #3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a karma.conf.js file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.

As discussed in karma-runner#3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
@karmarunnerbot
Copy link
Member

Build karma 509 completed (commit 9e4b79943c by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 508 completed (commit 9e4b79943c by @devoto13)

@johnjbarton johnjbarton merged commit 9c755e0 into karma-runner:master Feb 1, 2021
@devoto13 devoto13 deleted the revert-strict-params branch February 1, 2021 19:41
karmarunnerbot pushed a commit that referenced this pull request Feb 1, 2021
## [6.0.4](v6.0.3...v6.0.4) (2021-02-01)

### Bug Fixes

* **cli:** temporarily disable strict parameters validation ([#3641](#3641)) ([9c755e0](9c755e0)), closes [#3625](#3625)
* **client:** fix a false positive page reload error in Safari ([#3643](#3643)) ([2a57b23](2a57b23))
* ensure that Karma supports running tests on IE 11 ([#3642](#3642)) ([dbd1943](dbd1943))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 9, 2021
This was referenced Mar 14, 2021
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
…ner#3641)

As discussed in karma-runner#3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
## [6.0.4](karma-runner/karma@v6.0.3...v6.0.4) (2021-02-01)

### Bug Fixes

* **cli:** temporarily disable strict parameters validation ([karma-runner#3641](karma-runner#3641)) ([9c755e0](karma-runner@9c755e0)), closes [karma-runner#3625](karma-runner#3625)
* **client:** fix a false positive page reload error in Safari ([karma-runner#3643](karma-runner#3643)) ([2a57b23](karma-runner@2a57b23))
* ensure that Karma supports running tests on IE 11 ([karma-runner#3642](karma-runner#3642)) ([dbd1943](karma-runner@dbd1943))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants