Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): echo the hostname rather than listenAddress #3532

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

johnjbarton
Copy link
Contributor

When these differ the hostname is clearer.

@johnjbarton johnjbarton requested a review from kyliau June 11, 2020 22:58
@karmarunnerbot
Copy link
Member

Build karma 312 completed (commit cd9a5230ca by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 311 completed (commit cd9a5230ca by @johnjbarton)

lib/server.js Show resolved Hide resolved
@AppVeyorBot
Copy link

Build karma 2710 completed (commit cd9a5230ca by @johnjbarton)

The listenAddress is an IP level number, which may be "::" on IPV6.
The hostname is a string set in a /etc config file.
When these differ the hostname is clearer.
@karmarunnerbot
Copy link
Member

Build karma 320 failed (commit 1f2dd6c3ef by @johnjbarton)

@AppVeyorBot
Copy link

Build karma 2718 failed (commit eb29237236 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 319 completed (commit eb29237236 by @johnjbarton)

@johnjbarton johnjbarton merged commit ebe7ce4 into karma-runner:master Jul 28, 2020
karmarunnerbot pushed a commit that referenced this pull request Jul 28, 2020
## [5.1.1](v5.1.0...v5.1.1) (2020-07-28)

### Bug Fixes

* **server:** echo the hostname rather than listenAddress ([#3532](#3532)) ([ebe7ce4](ebe7ce4))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
…r#3532)

The listenAddress is an IP level number, which may be "::" on IPV6.
The hostname is a string set in a /etc config file.
When these differ the hostname is clearer.
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
## [5.1.1](karma-runner/karma@v5.1.0...v5.1.1) (2020-07-28)

### Bug Fixes

* **server:** echo the hostname rather than listenAddress ([karma-runner#3532](karma-runner#3532)) ([ebe7ce4](karma-runner@ebe7ce4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants