-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testacular fails to launch on Windows: Cannot call method 'isDirectory' of undefined #332
Comments
This is a bug in glob@3.1.18. I've added an issue: isaacs/node-glob#53 |
Does updating to the latest rimraf cause issues as well ? Anyway, testacular dependencies are frozen for now, we gonna update them manually. I just pushed canary release to npm. |
With the new canary release everything appears to work as expected for me. Thanks @vojtajina |
I didn't test rimraf specifically, sorry. Time constraints. Thanks for push a new canary release. |
So, it was Windows only issue, right ? Fixed glob 3.1.19 should be out, can you guys try it out, if it's fixed ? So that we can update dependencies to latest glob ? |
@vojtajina Yeah, this was Windows only. glob created paths which did not exist on Windows. For me |
An update that occured today to one of the dependencies of testacular has caused testacular@canary it start failing on windows.
Repro:
Expected:
Successful run
Actual:
Run fails immediately after browser launch
Reviewing the dependencies that had changed today shows only glob, rimraf, or (transitively) graceful-fs.
Workaround:
Forcing glob 3.1.17 and rimraf 2.1.2 avoids this issue.
https://github.com/testacular/testacular/commit/36e87d802b266b19423cd520f19c305856129842 addresses this issue but that change is not available even in canary release.
Suggest release of next canary build as soon as possible.
The text was updated successfully, but these errors were encountered: