Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update platformEffector.js for tag methods #598

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix: Update platformEffector.js for tag methods #598

merged 1 commit into from
Feb 9, 2025

Conversation

dragoncoder047
Copy link
Contributor

It was using .is() with a component ID. In v4000 this doesn't work anymore.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 24, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@598

commit: 194fbb0

@lajbel lajbel self-assigned this Feb 9, 2025
@lajbel lajbel added the cherry-pick This PR needs be cherry-picked for compability label Feb 9, 2025
@lajbel lajbel merged commit 26b77d5 into kaplayjs:master Feb 9, 2025
2 checks passed
@dragoncoder047 dragoncoder047 deleted the patch-2 branch February 9, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lajbel lajbel lajbel approved these changes

Assignees

@lajbel lajbel

Labels
cherry-pick This PR needs be cherry-picked for compability
Projects
KAPLAY.js Post Production
Status: Cherry Pick
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragoncoder047 @lajbel