isPartiallyOnScreen method #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isPartiallyOnScreen isOffScreen
asturur
reviewed
Mar 26, 2018
src/mixins/object_geometry.mixin.js
Outdated
| /** | ||
| * Checks if object is partially contained within the canvas with current viewportTransform | ||
| * the check is done stopping at first point that appears off screen | ||
| * @param {Boolean} [calculate] use coordinates of current position instead of .oCoords |
There was a problem hiding this comment.
use coordinates of current position, calculated just in time, instead of precalculated .aCoords
Also the check is made with intersection, the old comment does not really apply anymore.
the check is done stopping at first point that appears off screen is not really relevant in this implementation.
There was a problem hiding this comment.
apply to the other function too.
asturur
reviewed
Mar 26, 2018
test/unit/object_geometry.js
Outdated
| cObj.top = -1000; | ||
| cObj.setCoords(); | ||
| assert.equal(cObj.isPartiallyOnScreen(cObj.aCoords), false, 'object is not partially on screen because it is outside the canvas'); | ||
| }); |
There was a problem hiding this comment.
we have more test to cover and edge cases i believe. Intersect can return true for coincidents segments too.
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* appears * new methods isPartiallyOnScreen isOffScreen * UT * test * comment improved * removed isOffScreen * removed isOffScreen * Update object_geometry.mixin.js * Update object_geometry.mixin.js * lint... * omg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4823,
Issue: to know if the object is partially off screen, completely off screen.
Solution: create a simple helper methods which return boolean for object partially off screen
isPartiallyOnScreen, completely offscreenisOffScreen.