Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the mouse over/ mouse out event fire in the mouseMove events only #4283

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Move the mouse over/ mouse out event fire in the mouseMove events only #4283

merged 1 commit into from
Sep 6, 2017

Conversation

asturur
Copy link
Member

@asturur asturur commented Sep 3, 2017 •
edited
Loading

I moved the function out for 2 reasons:

  1. is not right to get an event fired as a side effect of running findTarget
  2. mouse enter, mouse leave belong to mouse move and not also to mousedown, mouseup, mousewheel.

@asturur
Copy link
Member Author

asturur commented Sep 3, 2017

@ncou this could influence that bug about event firing.

@asturur asturur mentioned this pull request Sep 3, 2017
Closed
@asturur asturur merged commit 860b7a7 into master Sep 6, 2017
@asturur asturur deleted the 2-fixes branch September 16, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asturur