New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for itext clearing out the selection area #3538

Merged

asturur merged 1 commit into master from textselection

Dec 17, 2016

Member

asturur commented Dec 17, 2016

closes #3505

There where errors and optimization possibilities:

after a mouse up the text was redrawn, using a cachied copied. the code for drawing the selection was inside the cache creation, and so it was not executed during the faster drawing. this was the main error.
after mouse up there was no need to re render, this is an optimization
during keypresses of arrows where just the cursor selection changes, there is no need for a full canvas redraw. this is an optimization


          fix selection clearing

9a20d37

asturur merged commit 41cc29a into master

asturur deleted the textselection branch

December 26, 2016 19:07

asturur added a commit that referenced this pull request


          fix selection clearing (#3538)

a99ea40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet