Trigger mouse over on canvas enter #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Oct 31, 2016
| var target = this._hoveredTarget || null; | ||
| this.fire('mouse:over', { target: target, e: e }); | ||
| this._hoveredTarget = null; | ||
| target && target.fire('mouseenter', { e: e }); |
There was a problem hiding this comment.
i think mouseenter is our mouseover.
But beside that, if you do not find any target, this.findTarget(e) why do you want to fire the event for the last hoverdTarget ?
|
Thanks @stefanhayden i left a comment on the code, i m not sure of something. |
|
you were right. So we only fire this event if there is no target. we also set the _hoveredTarget to null or mouse:out reports undefined instead of null for the target. |
|
nice thanks! |
asturur
pushed a commit
that referenced
this pull request
Nov 12, 2016
* fire a mouse:over event once when mouse enters the canvas * only fire if we don't find a target * only fire if we find no target and set the hoveredTarget to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about in #3384 this adds the existing
mouse:overevent to fire when the mouse enters the canvas.If the mouse enters the canvas and there is no target the fire the event. We need to do a check if there is a target, other wise the event will fire 2 times on entering the canvas with an object on the edge. once with null and once with the target,