Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search the target again on mouse up #2902

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Search the target again on mouse up #2902

merged 1 commit into from
Apr 25, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Apr 25, 2016

On mouse up event the target is taken from the current transform even when the transform produced no action.

If we decide to check the target again on mouse up we have always the correct target.
It may appen that on a normal click over the object we will search it twice.

When a target has movement locked or scaling or rotation locked, the mouse will move away from the target during a transform operation, a transform that may produce no effect. In this case the mouse up may happen hovering a different object and checking the new boolean actionPerformed we can find it.

closes #2508

@asturur asturur changed the title Update canvas_events.mixin.js Search the target again on mouse up Apr 25, 2016
@asturur asturur merged commit b95b4d2 into fabricjs:master Apr 25, 2016
@asturur asturur deleted the TargetMouseUp branch April 25, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse up returning target of mouse down after performing drag operation
1 participant