You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ODF restricts dataset name format to the grammar of domain names for compatibility with mechanisms like HTTP gateways and IPNS when dataset name appears in a subdomain. Subdomains are matched as case-insensitive.
We likely don't want to allow datasets fooBar and FooBar and users alice and alIce to exist in our system due to risk of impersonation
Finally the newly-introduced DatasetRefPattern also matches aliases as case-insensitive
Proposal
Spell out how case (in)sensitivity works in ODF spec
Equality checks of DatasetName and AccountName should be made case-insensitive
DatasetRepository implementations should be updated to case-insensitive comparisons when detecting name collisions
Along the way we should revisit how equality is implemented for composite types like DatasetRef, e.g. cases like DatasetRef::Alias("alice/foo") == DatasetRef::Handle("did:odf:abc", "alice/fool")
The text was updated successfully, but these errors were encountered:
Problem
fooBar
andFooBar
and usersalice
andalIce
to exist in our system due to risk of impersonationDatasetRefPattern
also matches aliases as case-insensitiveProposal
DatasetName
andAccountName
should be made case-insensitiveDatasetRepository
implementations should be updated to case-insensitive comparisons when detecting name collisionsDatasetRef
, e.g. cases likeDatasetRef::Alias("alice/foo") == DatasetRef::Handle("did:odf:abc", "alice/fool")
The text was updated successfully, but these errors were encountered: