Add unit tests

Author: rmn-boiko

src/domain/opendatafabric/src/identity/dataset_identity.rs

@@ -223,7 +223,7 @@ impl DatasetName {
         DatasetRef::Alias(DatasetAlias::new(None, self))
     }
 
-    fn lowercase_eq(&self, other: &Self) -> bool {
+    pub fn lowercase_eq(&self, other: &Self) -> bool {
         self.to_lowercase() == other.to_lowercase()
     }
 }
@@ -262,7 +262,12 @@ impl DatasetAliasPattern {
     }
 
     pub fn matches(&self, dataset_handle: &DatasetHandle) -> bool {
-        (self.account_name.is_none() || self.account_name == dataset_handle.alias.account_name)
+        ((self.account_name.is_none() && dataset_handle.alias.account_name.is_none())
+            || self
+                .account_name
+                .as_ref()
+                .unwrap()
+                .lowercase_eq(dataset_handle.alias.account_name.as_ref().unwrap()))
             && self
                 .dataset_name_pattern
                 .matches(&dataset_handle.alias.dataset_name)
@@ -311,7 +316,7 @@ newtype_str!(
 );
 
 impl AccountName {
-    fn lowercase_eq(&self, other: &Self) -> bool {
+    pub fn lowercase_eq(&self, other: &Self) -> bool {
         self.to_lowercase() == other.to_lowercase()
     }
 }

src/domain/opendatafabric/tests/tests/test_dataset_identity.rs

@@ -233,3 +233,55 @@ fn test_dataset_refs_conversions() {
         alias: DatasetAlias::try_from("bar").unwrap(),
     });
 }
+
+#[test]
+fn test_dataset_alias_eq() {
+    assert_eq!(
+        DatasetAlias::from_str("account/net.example.com").unwrap(),
+        DatasetAlias::from_str("aCCouNt/net.ExaMplE.coM").unwrap(),
+    );
+    assert_eq!(
+        DatasetAlias::from_str("account/net.example.com").unwrap(),
+        DatasetAlias::from_str("account/net.example.com").unwrap(),
+    );
+    assert_eq!(
+        DatasetAlias::from_str("net.example.com").unwrap(),
+        DatasetAlias::from_str("net.ExaMplE.coM").unwrap(),
+    );
+    assert_ne!(
+        DatasetAlias::from_str("account/net.example.com").unwrap(),
+        DatasetAlias::from_str("aCCouNt1/net.eXamPle.cOm").unwrap(),
+    );
+    assert_ne!(
+        DatasetAlias::from_str("account1/net.example.com").unwrap(),
+        DatasetAlias::from_str("account/net.example.com").unwrap(),
+    );
+    assert_ne!(
+        DatasetAlias::from_str("net.example.com").unwrap(),
+        DatasetAlias::from_str("account/net.example.com").unwrap(),
+    );
+}
+
+#[test]
+fn test_dataset_remote_alias_eq() {
+    assert_eq!(
+        DatasetAliasRemote::from_str("repository/net.example.com").unwrap(),
+        DatasetAliasRemote::from_str("repository/net.ExaMplE.coM").unwrap(),
+    );
+    assert_eq!(
+        DatasetAliasRemote::from_str("repository/net.example.com").unwrap(),
+        DatasetAliasRemote::from_str("repository/net.example.com").unwrap(),
+    );
+    assert_eq!(
+        DatasetAliasRemote::from_str("repository/account/net.example.com").unwrap(),
+        DatasetAliasRemote::from_str("repository/AccOuNt/net.ExaMplE.coM").unwrap(),
+    );
+    assert_ne!(
+        DatasetAliasRemote::from_str("repository/net.example.com").unwrap(),
+        DatasetAliasRemote::from_str("rEpoSitOry/net.ExaMplE.coM").unwrap(),
+    );
+    assert_ne!(
+        DatasetAliasRemote::from_str("repository/account/net.example.com").unwrap(),
+        DatasetAliasRemote::from_str("repository/net.example.com").unwrap(),
+    );
+}

src/infra/core/src/repos/dataset_repository_local_fs.rs

@@ -810,8 +810,9 @@ impl DatasetStorageStrategy for DatasetMultiTenantStorageStrategy {
                     )
                     .await?;
 
-                if candidate_dataset_alias.dataset_name.to_lowercase()
-                    == dataset_alias.dataset_name.to_lowercase()
+                if candidate_dataset_alias
+                    .dataset_name
+                    .lowercase_eq(&dataset_alias.dataset_name)
                 {
                     return Ok(DatasetHandle::new(dataset_id, candidate_dataset_alias));
                 }

src/infra/core/src/utils/datasets_filtering.rs

@@ -161,12 +161,8 @@ pub fn matches_remote_ref_pattern(
         DatasetRefAnyPattern::PatternRemote(repo_name, account_name, dataset_name_pattern) => {
             repo_name == &dataset_alias_remote.repo_name
                 && (dataset_alias_remote.account_name.is_some()
-                    && account_name.to_lowercase()
-                        == dataset_alias_remote
-                            .account_name
-                            .as_ref()
-                            .unwrap()
-                            .to_lowercase())
+                    && account_name
+                        .lowercase_eq(dataset_alias_remote.account_name.as_ref().unwrap()))
                 && dataset_name_pattern.matches(&dataset_alias_remote.dataset_name)
         }
     }
@@ -202,7 +198,8 @@ pub fn matches_local_ref_pattern(
         }
         DatasetRefAnyPattern::PatternAmbiguous(account_name, dataset_name_pattern) => {
             let account_name = AccountName::from_str(&account_name.pattern).unwrap();
-            Some(account_name) == dataset_handle.alias.account_name
+            (dataset_handle.alias.account_name.is_some()
+                && account_name.lowercase_eq(dataset_handle.alias.account_name.as_ref().unwrap()))
                 && dataset_name_pattern.matches(&dataset_handle.alias.dataset_name)
         }
     }