Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem saving scripts #70

Closed
gatovelho opened this issue Apr 1, 2016 · 7 comments
Closed

problem saving scripts #70

gatovelho opened this issue Apr 1, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@gatovelho
Copy link

Hi,
thank you very much for sharing mqtt-spy.

I am no software type so I may be saying something very wrong. Hope not.

I am using "mqtt-spy-0.4.0-jar-with-dependencies "on windows 10 home (32 bits)

an d I am having problems with directories .
Notably (but not only) I am not being able to save scripts. They just vanish.
Had to create a few of them them by hand.
The demon also fails creating files even the basic default script.

Adding some log below.

Best regards,
CS

2016-04-01 08:40:54,475 ERROR [JavaFX Application Thread ] [SpyUncaughtExceptionHandler ] - Thread Thread[JavaFX Application Thread,5,main] failed with java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
....(removed)
...
... 44 more
Caused by: java.lang.IllegalArgumentException: URI is not hierarchical
at java.io.File.(Unknown Source)
at pl.baczkowicz.mqttspy.ui.NewPublicationController.createScriptFromMessage(NewPublicationController.java:873)
at pl.baczkowicz.mqttspy.ui.NewPublicationController.saveAsScript(NewPublicationController.java:846)
at pl.baczkowicz.mqttspy.ui.NewPublicationController.saveCurrentAsScript(NewPublicationController.java:804)

@kamilfb kamilfb added the bug label Apr 1, 2016
@kamilfb kamilfb added this to the 0.5.0 milestone Apr 1, 2016
@kamilfb kamilfb self-assigned this Apr 1, 2016
@kamilfb
Copy link
Owner

kamilfb commented Apr 1, 2016

Hi. Thanks for reporting this issue. I've managed to reproduce it. Will try to get a fix for that soon.

@kamilfb
Copy link
Owner

kamilfb commented Apr 1, 2016

Fixed in 0.5.0 - could you try it out?

@gatovelho
Copy link
Author

Thank you.
I will submit feedback after doing some work

@gatovelho
Copy link
Author

Did some testing.
It has improved, but still has some problems.
the good: it now looks at default directory for publishing scripts. Finds the script if it is there.
the bad: is not able to "publish from script" when Topic is empty, even if has the Topic embedded in the script. If we put even a space in the topic, then it gets published.
also bad: does not look for the scripts in the "directory with publication scripts" (set by hand). Those scripts however do show up -and execute correctly- after refreshing "script publications" windows and starting them from there by double-clicking.
There are some odd interactions but methinks the may get fixed after this issue is addressed.
Thank you again for your support.

@kamilfb kamilfb modified the milestones: 0.6.0, 0.5.0 Apr 2, 2016
@kamilfb
Copy link
Owner

kamilfb commented Apr 2, 2016

Many thanks for the feedback. I will look into it further...

@gatovelho
Copy link
Author

Just ocurred to me: strictly speaking, this topic should be considered closed. I found no problems when saving scripts in the new version 050.
I could open a new issue on the difficulties reported above if you think that is the proper way.
Regards

@kamilfb
Copy link
Owner

kamilfb commented Apr 3, 2016

Hi. Sounds like a good plan! I'll close this one as fixed and if you don't mind, please open new issue(s) for the other problem(s). Cheers!

@kamilfb kamilfb closed this as completed Apr 3, 2016
@kamilfb kamilfb modified the milestones: 0.5.0, 0.6.0 Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants