From 011cbcae349dc2db0d43c1de6a08f9263ef56af3 Mon Sep 17 00:00:00 2001 From: "yuval.keidar" Date: Mon, 5 Jul 2021 14:24:03 +0300 Subject: [PATCH] fix(FEC-10832): captions not shown in change media from media with 608 captions Issue: native captions doesn't change to disable in change media. Solution: always disable native text tracks on change media --- src/hls-adapter.js | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/hls-adapter.js b/src/hls-adapter.js index acae8471..2523a16c 100644 --- a/src/hls-adapter.js +++ b/src/hls-adapter.js @@ -744,7 +744,7 @@ export default class HlsAdapter extends BaseMediaSourceAdapter { _selectNativeTextTrack(textTrack: TextTrack): void { const selectedTrack = this._nativeTextTracksMap[textTrack.index]; if (selectedTrack) { - this._disableNativeTextTracks(); + this.disableNativeTextTracks(); selectedTrack.mode = this._config.subtitleDisplay ? 'showing' : 'hidden'; this._notifyTrackChanged(textTrack); } @@ -754,17 +754,6 @@ export default class HlsAdapter extends BaseMediaSourceAdapter { this._onTrackChanged(textTrack); } - /** - * Disables all the video element text tracks. - * @private - * @returns {void} - */ - _disableNativeTextTracks(): void { - Array.from(this._videoElement.textTracks).forEach(track => { - track.mode = 'disabled'; - }); - } - /** Hide the text track * @function hideTextTrack * @returns {void} @@ -775,7 +764,7 @@ export default class HlsAdapter extends BaseMediaSourceAdapter { if (this._hls.subtitleTracks.length) { this._hls.subtitleTrack = -1; } else { - this._disableNativeTextTracks(); + this.disableNativeTextTracks(); } } }