fix(FEC-8233): handle media & error recovering #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaming the callback function, cleaning the event listener on adapter destruction.
OrenMe
suggested changes
May 28, 2018
src/hls-adapter.js
Outdated
| @@ -678,9 +699,20 @@ export default class HlsAdapter extends BaseMediaSourceAdapter { | |||
| HlsAdapter._logger.error("cannot recover, last media error recovery failed"); | |||
| } | |||
| } | |||
| this._videoElement.addEventListener(EventType.LOADED_METADATA, this._onRecoveredCallback); | |||
There was a problem hiding this comment.
@odedhutzler you would want to this only if (recover) { ... }.
Actually, because we only add the listener after we call _recoverDecodingError or _recoverSwapAudioCodec there's a chance that this might not even pick up, so better return this to be inlined twice, above and before each call to the recover handlers
OrenMe
previously approved these changes
May 28, 2018
OrenMe
reviewed
May 28, 2018
OrenMe
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the media recovered successfully, trigger media recovered event
CheckLists