-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add show_legend_state #1173
Conversation
In the previous PR, it was advised to add state__value & state__uom classes to the render. |
totally agree, missed that myself. |
@akloeckner What is not covered (and MAY BE will be fixed in other PRs):
without keeping parts in separate elements. May be they should be placed both in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sorting most things out already! And sorry for re-opening some of the topics. :-)
I agree with your general assessment:
- Let's keep the UOM order for later. I also understand from your conversation that the usual classes generated a strange look. So, it is more than just adding known classes and spans and should thus be treated with more thought in another PR.
- Same for the whitespace. If the state and UOM parts become separate tags with flexible order, it will be up to the user anyways to add or remove whitespace.
I haven't actually downloaded, compiled and tested the changes yet. I'll approve the workflow run, so maybe you can check it out, @ildar170975? You'll have to wait for the code to successfully compile...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this PR. There is a js file to use for testing as usual in the "checks" section.
Let's merge it. Looks great. |
Thanks for bearing with us @JulienDeveaux! |
🎉 This PR is included in version 0.13.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Iterating on #1082 as I can't push into his repo