fix: legend indicators respect entity attribute configuration

[arychj]

When using attributes for entity states, the line picks up the new state location and respects the color thresholds, however the legend indicators do not.

Current behaivour

entities:
  - entity: sensor.sensor_1
    attribute: attribute_1
    name: ' '
  - entity: sensor.sensor_2
    attribute: attribute_1
    name: ' '
# ...

New behaviour

This updates the renderIndicator() function to use the existing getEntityState() which checks if an attribute has been configured, otherwise it falls back to the entity state.

[akloeckner]

Thanks! This looks like a very pointy fix.

@ildar170975, I don't use colour thresholds: Is this how it's supposed to work?

[ildar170975]

Hmmm, here it is said "attribute configuration".
I do not think I have recorded entities with numerical attributes, cannot test right now.
But there are issues with colored states, not attributes.
So let's start with a simpler case - state, not attribute.

1. No color thresholds:

type: custom:mini-graph-card
entities:
  - entity: sensor.xiaomi_cg_1_co2
    show_state: true
    state_adaptive_color: true
  - entity: sensor.xiaomi_cg_2_co2
    show_state: true
    state_adaptive_color: true
name: CO2
hours_to_show: 24
points_per_hour: 60
lower_bound: ~400

Here state labels & legend parts have correct colors:

2. Added color_thresholds:

color_thresholds:
  - value: 450
    color: orange
  - value: 550
    color: green
  - value: 650
    color: magenta
color_thresholds_transition: hard

Here both entities are "pink" - state labels & legend parts - since both entities are > 650:

3. A bit different color_thresholds - 2nd entity is supposed to be below last threshold:

color_thresholds:
  - value: 450
    color: orange
  - value: 550
    color: green
  - value: 665    #!!!!!!!
    color: magenta

And here state labels have correct colors, but a legend part for the 2nd entity is black (WRONG):

So, imho in both cases - showing a state or an attribute - a legend parts should have colors dependently on their current value.
Note that for a state label a color is set dependently on a state_adaptive_color option; but for a legend part a color should be set always.

---

Test for attributes: (graphs are not displayed since entities are not recorded)

1. No thresholds:

type: custom:mini-graph-card
entities:
  - entity: sensor.xiaomi_cg_1
    attribute: co2
    show_state: true
    state_adaptive_color: true
  - entity: sensor.xiaomi_cg_2
    attribute: co2
    show_state: true
    state_adaptive_color: true
name: CO2
hours_to_show: 24
points_per_hour: 60
lower_bound: ~400

Colors are OK for state labels & legend parts:

2. With thresholds:

color_thresholds:
  - value: 450
    color: orange
  - value: 550
    color: green
  - value: 650
    color: magenta
color_thresholds_transition: hard

Here state labels are OK (pink), but legend parts are both wrong:

[akloeckner]

So, imho in both cases - showing a state or an attribute - a legend parts should have colors dependently on their current value.

Thanks, that was what I was looking for. From your tests, it seems we still have some other issues. But this PR moves us in the right direction. 👍

I'm going to merge it then.

[ildar170975]

I'm going to merge it then.

At least we'll be able to test it then )))

[ildar170975]

@akloeckner
please tell me where to find a compiled js file

[akloeckner]

I'll publish a pre-release in a few minutes.

Also, I believe one of the actions creates a compiled js as an artifact. 🤔

[github-actions]

🎉 This PR is included in version 0.12.2-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[akloeckner]

Also, I believe one of the actions creates a compiled js as an artifact. 🤔

There should be one here:

• Click on "Checks" for the PR
• Select "CI"
• Scroll down to "Artifacts"
• Download one of the zips
• It should contain the compiled .js

[ildar170975]

After PR merged - became better, but a black indicator still shown: #1116
i.e. the old bug is still there