Convert extended Form to native class, providing compatibility with ember-bootstrap 5.1+ #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber-bootstrap 5.1+
jelhan
approved these changes
Apr 22, 2022
|
|
||
| await m.validate(); | ||
| if (!model.get('isValid')) { | ||
| throw new Error(); |
There was a problem hiding this comment.
Should we add a meaningful error message? I know we haven't had one before. Just noticed when reviewing. So not required for this one to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unblock ember-bootstrap/ember-bootstrap#1775 (took me way to long to get back to this...)
Tested locally with
yalcand that branch of ember-bootstrap.