Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a bug in src/nnet/nnet-lstm-projected.h #2694

Closed
cbtpkzm opened this issue Sep 11, 2018 · 1 comment
Closed

Find a bug in src/nnet/nnet-lstm-projected.h #2694

cbtpkzm opened this issue Sep 11, 2018 · 1 comment

Comments

@cbtpkzm
Copy link

cbtpkzm commented Sep 11, 2018

`

// apply the gradient clipping,
if (clip_gradient_ > 0.0) {
  w_gifo_x_corr_.ApplyFloor(-clip_gradient_);
  w_gifo_x_corr_.ApplyCeiling(clip_gradient_);
  w_gifo_r_corr_.ApplyFloor(-clip_gradient_);
  w_gifo_r_corr_.ApplyCeiling(clip_gradient_);
  bias_corr_.ApplyFloor(-clip_gradient_);
  bias_corr_.ApplyCeiling(clip_gradient_);
  w_r_m_corr_.ApplyFloor(-clip_gradient_);
  w_r_m_corr_.ApplyCeiling(clip_gradient_);
  peephole_i_c_corr_.ApplyFloor(-clip_gradient_);
  peephole_i_c_corr_.ApplyCeiling(clip_gradient_);
  peephole_f_c_corr_.ApplyFloor(-clip_gradient_);
  peephole_f_c_corr_.ApplyCeiling(clip_gradient_);
  peephole_o_c_corr_.ApplyFloor(-clip_gradient_);
  peephole_o_c_corr_.ApplyCeiling(clip_gradient_);
}

`
Here the clip_gradient_ should be grad_clip_?

@danpovey
Copy link
Contributor

fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants