Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When open sidebar, it will push the content out of the container #278

Closed
justforuse opened this issue Jun 26, 2018 · 7 comments
Closed

When open sidebar, it will push the content out of the container #278

justforuse opened this issue Jun 26, 2018 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@justforuse
Copy link

Configuration

  • Operating system with its version:
  • Browser with its version:
  • Hugo version: 0.42.1
  • Tranquilpeak version: 0.4.3-BETA
  • Do you reproduce on https://tranquilpeak.kakawait.com demo?: yes

Actual behavior

qq 20180627010328

Expected behavior

Steps to reproduce the behavior

It performs well when set cleanReading: false

@johnsoncodehk
Copy link
Contributor

This problem fixed on my pages, but the animation effect is different, please let me know if the author wants to merge.

Repository: https://github.com/johnsoncodehk/hugo-tranquilpeak-theme
Demo: https://johnsoncodehk.github.io/games/peace-alien/

@kakawait
Copy link
Owner

@johnsoncodehk I'm totally open to your way to do. Feel free to open a PR or give me link a commit or something to see what's diff to apply

@kakawait kakawait added the bug Something isn't working label Jul 11, 2018
@johnsoncodehk
Copy link
Contributor

I made these changes: johnsoncodehk@f4d5b32
If you think this is ok, I will submit a PR.

@kakawait
Copy link
Owner

To be honest I'm not a pro CSS dev so I appreciate some help from community like you just do it now :) Thank you

@johnsoncodehk
Copy link
Contributor

I guess you are a designer when I change your code, thank you for this beautiful theme :)

@johnsoncodehk
Copy link
Contributor

I updated my branch, the content width is no longer scaled.

Commit: johnsoncodehk@ebff1ac
pixel-light

@kakawait kakawait added enhancement New feature or request feature request and removed bug Something isn't working labels Aug 26, 2018
@kakawait kakawait added this to the 0.4.4-BETA milestone Aug 26, 2018
@kakawait
Copy link
Owner

@johnsoncodehk that awesome thank I will integrate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants