-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(client): reuse snpb.SubscribeResponse in RPC handler #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2024
37baf23
to
889b990
Compare
4f7103f
to
cc39617
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
- Coverage 49.73% 49.67% -0.06%
==========================================
Files 235 235
Lines 20715 20717 +2
==========================================
- Hits 10302 10291 -11
- Misses 9774 9783 +9
- Partials 639 643 +4 ☔ View full report in Codecov by Sentry. |
889b990
to
01fbf39
Compare
cc39617
to
f59cbe0
Compare
01fbf39
to
c39f3e6
Compare
f59cbe0
to
4baaff2
Compare
c39f3e6
to
d604b6f
Compare
4baaff2
to
cd283ae
Compare
d604b6f
to
10a0efb
Compare
cd283ae
to
0c1d77a
Compare
10a0efb
to
40506df
Compare
0c1d77a
to
578b928
Compare
40506df
to
8014ece
Compare
578b928
to
1b8f5a0
Compare
hungryjang
approved these changes
Mar 5, 2024
This pull request optimizes `internal/storagenode/client.(*LogClient).Subscribe`. It reuses `snpb.SubscribeResponse` to reduce heap allocations. Note that it does not reuse the byte slice in the `snpb.SubscribeResponse`. It only reuses the struct `snpb.SubscribeResponse` itself.
1b8f5a0
to
890508d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request optimizes
internal/storagenode/client.(*LogClient).Subscribe
. It reusessnpb.SubscribeResponse
to reduce heap allocations. Note that it does not reusethe byte slice in the
snpb.SubscribeResponse
. It only reuses the structsnpb.SubscribeResponse
itself.