Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): add gogoproto codec to grpc servers #581

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Sep 11, 2023

What this PR does

This PR provides a new function to create a gRPC server. It helps the gRPC server use gogoproto
codec.

Which issue(s) this PR resolves

Update #235.

@ijsong ijsong requested a review from hungryjang as a code owner September 11, 2023 03:13
@ijsong ijsong self-assigned this Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.03% 🎉

Comparison is base (e2d1a05) 61.68% compared to head (5e1f344) 61.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##           ee_test_logger     #581      +/-   ##
==================================================
+ Coverage           61.68%   61.71%   +0.03%     
==================================================
  Files                 138      139       +1     
  Lines               18879    18881       +2     
==================================================
+ Hits                11645    11653       +8     
+ Misses               6654     6646       -8     
- Partials              580      582       +2     
Files Changed Coverage Δ
internal/admin/testing.go 44.68% <0.00%> (ø)
internal/storagenode/testing.go 70.41% <0.00%> (ø)
internal/admin/admin.go 61.58% <100.00%> (ø)
internal/metarepos/raft_metadata_repository.go 76.86% <100.00%> (+0.09%) ⬆️
internal/storagenode/logstream/testing.go 54.38% <100.00%> (ø)
internal/storagenode/storagenode.go 72.29% <100.00%> (+0.31%) ⬆️
pkg/rpc/server.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This PR provides a new function to create a gRPC server. It helps the gRPC server use gogoproto
codec.
@ijsong
Copy link
Member Author

ijsong commented Oct 4, 2023

Merge Activity

  • Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
  • Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.

Base automatically changed from ee_test_logger to main October 4, 2023 07:31
@ijsong ijsong merged commit 6127cd2 into main Oct 4, 2023
@ijsong ijsong deleted the grpc_server_codec branch October 4, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants