feat(admin): check cluster id in mrmanager

[ijsong]

What this PR does

This PR adds codes to check cluster id in mrmanager. Because the admin server doesn't have explicit health checking, comparing cluster id is performed in ClusterMetadataViewer.
In the next PR, checking the replication factor will be added.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553
              • PR feat(all): change type of ClusterID from uint32 to int32 #566
                • PR refactor(all): make cluster id flag common #567
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555 👈
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (efe2d44) 61.12% compared to head (b958fe0) 61.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           mr_no_large_lock     #555      +/-   ##
====================================================
+ Coverage             61.12%   61.24%   +0.12%     
====================================================
  Files                   144      144              
  Lines                 19241    19242       +1     
====================================================
+ Hits                  11761    11785      +24     
+ Misses                 6888     6873      -15     
+ Partials                592      584       -8     

Files	Coverage Δ
tests/it/testenv.go	34.59% <100.00%> (+0.05%)	⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 5:10 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 5:10 AM: @ijsong merged this pull request with Graphite.